[cfe-dev] add-override-specifier example tool

David Blaikie dblaikie at gmail.com
Mon Jul 2 09:24:40 PDT 2012

I haven't had a chance to look at this in great detail, but at a
glance it doesn't seem to cover an idea I had, so I'll mention it

Should you consider removing explicit 'virtual' from functions you're
marking up as 'override' (since the latter implies the former) -
perhaps as an option? (I can understand some people might like the
code layout/obviousness of having 'virtual' at the start of every
declaration that's virtual - overriden or otherwise)

[also - see my comment on Sam Panzer's thread regarding migration
tools & ongoing validators/autoformatters which seems somewhat

- David

On Sun, Jul 1, 2012 at 5:19 PM, Philip Dunstan <phil at philipdunstan.com> wrote:
> Again, with a few bug fixes...
> Phil
> --
> Philip Dunstan
> phil at philipdunstan.com
> www.philipdunstan.com
> On Sun, Jul 1, 2012 at 11:31 PM, Philip Dunstan <phil at philipdunstan.com>
> wrote:
>> Hi everyone,
>> I'd like to submit my refactoring tool that adds the override specifier to
>> appropriate virtual functions to the clang tooling branch. Given the recent
>> discussion on this list about creating a larger refactoring tool with many
>> different C++11 refactoring options  I thought I would submit it here for
>> discussion before submitting it to cfe-commit list.
>> Regardless of the discussion on the larger tool, I think that the
>> add-override-specifier example is still a useful example of the work that
>> has been done in the tooling branch. It includes writing a custom ASTMatcher
>> to identify virtual functions which are candidates for the override keyword.
>> It also demonstrates a different problem than the rename-method example and
>> remove-cstr-calls tool on which it is based.  If there isn't any opposition
>> to this, I will submit it to cfe-commit.
>> I am still not entirely happy with the technique used to identify where
>> the override keyword should be inserted and would welcome discussion on this
>> problem.
>> Thanks,
>> Phil
>> --
>> Philip Dunstan
>> phil at philipdunstan.com
>> www.philipdunstan.com
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

More information about the cfe-dev mailing list