[cfe-dev] Fix PR13444 - wrong mangling of "const char * const *" and friends

João Matos ripzonetriton at gmail.com
Fri Aug 31 08:47:42 PDT 2012


Nice patch, LGTM.

I really like the clean up of all the pointer qualifier mangling
into manglePointerQualifiers, makes the code much simpler to follow.


On Fri, Aug 31, 2012 at 12:55 PM, Timur Iskhodzhanov <timurrrr at google.com>wrote:

> Hi John,
>
> Can you please review this patch?
> This fixes http://llvm.org/PR13444 as well as a large part of
> http://llvm.org/PR13182 plus adds quite a few tests.
>
> With this patch plus the pending PR13455 patch I don't get link-time
> problems when building SPEC CPU2006 tests anymore!
> (I'm only testing the files that are compileable with Clang++ though,
> e.g. no RTTI users etc)
>
> FTR, the SplitQualType / isa<ArrayType> part was mostly taken from
> ItaniumMangle.cpp
>
> Thanks in advance,
> Timur Iskhodzhanov,
> Google Russia
>



-- 
João Matos
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20120831/bf7b4fba/attachment.html>


More information about the cfe-dev mailing list