[cfe-dev] [PATCH] extend __interface support

David Robins llvm at davidrobins.net
Mon Aug 13 06:30:07 PDT 2012


On Mon, Aug 13, 2012 at 12:11:41AM -0700, Eli Friedman wrote:
> Do clang's diagnostics with your patch match MSVC's diagnostics for
> examples like the following?
> 
> __interface X;
> struct X;
> __interface Y;
> class Y;

MSVC 10 (2010) emits (with /Wall; nothing without):

  int.cpp(4) : warning C4099: 'Y' : type name first seen using 'struct'
  now seen using 'class'
          int.cpp(3) : see declaration of 'Y'

Clang with patch emits (with -Wall; nothing without):

  int.cpp:4:1: warning: class 'Y' was previously declared as a struct
        [-Wmismatched-tags]
  class Y;
  ^
  int.cpp:3:13: note: previous use is here
  __interface Y;
              ^

This looks like a good match.

> It looks like your patch has a few lines which run over 80 columns.

I'll fix any lines > 80 columns after resolving other issues and before
resubmitting.




More information about the cfe-dev mailing list