[cfe-dev] [PATCH] Libc++ Windows fixes

[David Chisnall]

On 29 Sep 2011, at 00:42, Howard Hinnant wrote:

> 
> On Sep 28, 2011, at 6:17 PM, David Chisnall wrote:
> 
>> On 28 Sep 2011, at 22:45, Howard Hinnant wrote:
>> 
>>> I think FreeBSD should define _LLIBCPP_STABLE_APPLE_ABI too.  David?  And maybe with David's latest patch to FreeBSD, should also #define _LIBCPP_GET_C_LOCALE 0.
>> 
>> FreeBSD should now be mirroring the Apple implementation for anything xlocale related.  If there are any discrepancies, they are bugs and I'll fix them in libc, rather than hack around them in libc++.
>> 
>> I'm not entirely sure what defining _LLIBCPP_STABLE_APPLE_ABI means - perhaps it could be replaced with a more descriptive name?
> 
> See revision 140734, and let me know what needs fixing (hopefully nothing).

I just updated and now I see 3 fewer failures than the last time I ran it.  Looking good.  The atomics and support failures are caused by missing clang features, I think, and I'm pretty sure the thread timeout test failures are caused by crappy time support in my test VM.  

Thanks!

David