[cfe-dev] -fdiagnostics-format= design review : added enum to patch

[Erik Olofsson]

I think you intended this:
+    Opts.Format = 1;
+    Opts.ShowColumn = DiagnosticOptions::Msvc;

To be:
+    Opts.Format = DiagnosticOptions::Msvc;
+    Opts.ShowColumn = false;

At least in Visual Studio 2010 columns are supported with the following format:
t.c:(3,10)
I not entirely sure but I think you need ColNo-1 on MSVC

Also, shouldn't there be tests for this?

Regards,
Erik

From: cfe-dev-bounces at cs.uiuc.edu [mailto:cfe-dev-bounces at cs.uiuc.edu] On Behalf Of Andrew Fish
Sent: den 18 maj 2011 23:15
To: cfe-dev
Subject: Re: [cfe-dev] -fdiagnostics-format= design review : added enum to patch

Update patch to use an enum, per Doug's suggestion.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110519/4b786d32/attachment.html>