[cfe-dev] Interest in a -Wusing-namespace-in-headers?

[Elliot Glaysher (Chromium)]

Attached is a in-progress patch for a -Wusing-namespace-in-headers.
I'm not sure if this is something people would be interested in. If
there is, I'll continue working on this.

I do have two questions though:

1) How exactly should I be ordering the definitions in the .td files?
Is what I did fine?
2) The tests that I wrote as is don't work. The warning gets emitted,
but the test harness doesn't expect it despite the comment. I assume
this is because FindExpectedDiags() in DiagChecker.cpp explicitly only
looks in the main file for expected-* diagnostics. Is there any simple
way to fix this? Since the purpose of the warning is to trigger only
when not in the main file, I'll need to fix this somehow before I
submit this for real review...

Regards,

-- Elliot Glaysher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: using-namespace.diff
Type: text/x-patch
Size: 3229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110316/592d3a36/attachment.bin>