[cfe-dev] patch: stylistic improvements to SValBuilder

Ted Kremenek kremenek at apple.com
Mon Feb 28 12:01:45 PST 2011

These changes look great to me!

On Feb 27, 2011, at 11:56 PM, Zhanyong Wan (λx.x x) wrote:

> Hi Ted,
> I have uploaded a patch to http://codereview.appspot.com/4241044,
> which hopefully improves the coding style in SValBuilder.  It:
> - renames evalCastNL and evalCastL to evalCastFromNonLoc and
> evalCastFromLoc (avoid abbreviations that aren't well known).
> - makes all function parameter names start with a lower case letter
> for consistency and distinction from member variables.
> - avoids abbreviations in function parameter names.
> Would you please review it?  Let me know if I'm going too far. ;-)  Thanks,
> -- 
> Zhanyong

More information about the cfe-dev mailing list