[cfe-dev] [PATCH] Default implementation for ExternalASTSource's pure virtual functions

Douglas Gregor dgregor at apple.com
Thu Feb 24 11:46:09 PST 2011

Sent from my iPhone

On Feb 24, 2011, at 9:37 AM, Axel Naumann <Axel.Naumann at cern.ch> wrote:

> Hi,
> I'd suggest to provide default implementations for ExternalASTSource's
> pure virtual functions. Derived classes should actually not be required
> to implement them. See e.g. r126387 (offering an orthogonal lookup
> source through ExternalASTSource::LookupUnqualified()), and lldb.

Please put these definitions into a .cpp file. They'll never be inlined anyway. 

> Attached patch does that (+ cleanup of forward declarations).
> I think it's a semi-minor patch, so if there are no comments I'll commit
> it in 24 hours :-)
> Cheers, Axel.
> <ExternalASTSource_default_impl.diff>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

More information about the cfe-dev mailing list