[cfe-dev] patch: improving the add_clang_unittest() CMake function, and using it to add a target for unittests/Basic

NAKAMURA Takumi geek4civic at gmail.com
Tue Feb 15 20:36:52 PST 2011


Hello Wan,

It works well on my hosts, thank you!

Two minor things. They might be trivial and one's preference.

  - You may create a list as semicolon-separated string.
    eg) "gtest;gtest_main;clangFrontend"
    Then, separate_arguments(string) would not be needed.
  - Could you split a patch into two?
    1. improvement
    2. the rule for BasicTests.

ps. It can be ported to llvm/unittests, too :)

...Takumi



More information about the cfe-dev mailing list