[cfe-dev] making Subengine optional in GRState
kremenek at apple.com
Thu Feb 10 20:23:53 PST 2011
I'm happy with the patch as is. I'm considering eventually decoupling GRStateManager from GRSubEngine anyway, so I think this is a good initial step.
I've applied the patch here: r125362
On Feb 10, 2011, at 6:38 AM, Olaf Krzikalla wrote:
> Hi Ted,
> a while ago we already talked about making Subengine optional im GRStateManager. Back then I didn't want to have you commit the changes because I didn't know yet if it helps me. Now I safely can answer that question with "yes". In addition, due to all the recent directory movements I had some trouble to keep on track with my changes. So, please, if nothing else stands against it, can you commit the attached patch?
> One discussable point is the added GRStateManager ctor. We could use the ConstraintManagerCreator function there too, but only if we change the signature of that function from SubEngine& to SubEngine*.
> I don't see any other obstacles.
> Best regards
> Olaf Krzikalla
More information about the cfe-dev