[cfe-dev] [OpenCL patch] kernel attributes implementation

[Benyei, Guy]

Hi Pekka,

I agree that the right place to implement OpenCL specific metadata shouldn't be in target specific, since the attributes are not target specific. IMO, the right solution would be to implement this metadata in CodeGenFunction.cpp, next to the implementation of the "opencl.kernels" metadata.

Anyway, I chosen to implement is for the TCE target only due to the fact that reqd_work_group_size is implemented in this target only. It can be changed, of course.

Thanks
    Guy

-----Original Message-----
From: cfe-dev-bounces at cs.uiuc.edu [mailto:cfe-dev-bounces at cs.uiuc.edu] On Behalf Of Pekka J??skel?inen
Sent: Tuesday, December 20, 2011 12:50
To: cfe-dev at cs.uiuc.edu
Subject: Re: [cfe-dev] [OpenCL patch] kernel attributes implementation

On 12/20/2011 11:18 AM, Benyei, Guy wrote:
> I've implemented the handling of these new attributes in the TCE target
> info, since reqd_work_group_size attribute is already implemented there.
> I also use this target for testing.

Thanks! :)

There was some discussion about implementing these OpenCL C kernel
attributes some time ago [1]. The discussion somehow died.

The question raised there was why cannot we add these by default when
compiling OpenCL? This would enable pocl [2] to support these OpenCL
features for all LLVM targets. The OpenCL implementations that implement
the attributes in some other way can just ignore the metadata (except the
required work group size cannot be just ignored, AFAIK).

[1] http://lists.cs.uiuc.edu/pipermail/llvmdev/2011-December/046204.html
[2] https://launchpad.net/pocl

-- 
Pekka

_______________________________________________
cfe-dev mailing list
cfe-dev at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.