[cfe-dev] -ferror-limit omits part of last error message

[Nikola Smiljanic]

On Tue, Aug 16, 2011 at 8:26 PM, David Blaikie <dblaikie at gmail.com> wrote:

> Like this? (patch attached, no test cases yet) - I don't know if I
> should be doing something better than SetDelayedDiagnostic now that we
> don't really need to delay it at all.
>
>
 Your patch does the trick (the question about SetDelayedDiagnostic still
remains). Here are the test cases:

The first one checks if both error and note are emitted before the fatal
error, and that nothing is emitted afterwards
The second one checks that multiple notes are emitted correctly before the
fatal error, and that nothing is emitted afterwards

Should I include one more that checks that no fatal error is emitted when
the limit is 1 and there is only one error?

There is also a piece of code that allows notes to be attached to the fatal
error. I wanted to write a test for this but I'm not sure that this is used
anywhere (the only fatal error I can see is fatal_too_many_errors and there
are no notes being attached)?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110817/aa42b6be/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: error-limit.c
Type: text/x-csrc
Size: 463 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110817/aa42b6be/attachment.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: error-limit-multiple-notes.cpp
Type: text/x-c++src
Size: 784 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110817/aa42b6be/attachment.cpp>