[cfe-dev] [patch] Support for C++0x raw string literals

Craig Topper craig.topper at gmail.com
Wed Aug 10 00:20:53 PDT 2011


> +++ lib/Lex/TokenConcatenation.cpp      (working copy)
>
> +// IsStringPrefix - Return true if the buffer contains a string prefix
> +static inline bool IsStringPrefix(const char *Ptr, unsigned length,
>
> Please make this a proper doxygen context, and finish your thought in the comment :).
>
> Please make it take a StringRef instead of ptr+length.  This may also let you simplify its body, using startsWith etc.
>
> Please change the body of this function to be multiple if statements instead of one big ||/&& conglomeration :)

After testing gcc, I wonder if its worth all this trouble to detect
only string prefixes. gcc seems to not concatenate any identifier with
a string

-- 
~Craig




More information about the cfe-dev mailing list