[cfe-dev] OpenCL-specific image2d_t, image3d_t and sampler_t *revised*

[Douglas Gregor]

Sent from my iPhone

On Apr 15, 2011, at 3:50 PM, Tanya Lattner <lattner at apple.com> wrote:

> 
> On Apr 14, 2011, at 3:18 PM, Tanya Lattner wrote:
> 
>> I think we both have a lot of patches out here, so I guess we should try to get these resolved soon. Sorry for my delay in the matter.
>> 
>> General comments on the patch:
>> - Comments are needed on the OpenCLOtherType class, and member funcs. Comments needed on all the special OpenCL checks within the various parts.End comments with proper punctuation. I guess we could also get into an argument if its initialise or initialize? ;)
>> 
>> - Why are OpenCL types never serialized? This would need to be implemented before it could be checked in or otherwise things like PCH wont work.
>> 
>> - I'm not an expert in mangling, but wouldn't it be better to use something other than a number?
>> 
>> - In ConvertNewType, shouldn't it assert if the OpenCL other type is not recognized?
>> 
>> I'm not totally against combining these types into one class versus my implementation (which only addressed samplers).
> 
> However, I will say that these OpenCL types are all different, so I'd probably ask Doug what he thinks is the best to do from a Clang coding standard viewpoint (break them up into separate type classes or have them in one).

I don't like the idea of an OpenCLOtherType class, because it lumps together unrelated types.  The type classes should be meaningful, e.g., OpenCLImageType and OpenCLSamplerType. 

  - Doug

> -Tanya
> 
>> Thanks,
>> Tanya
>> 
>> 
>> 
>> On Apr 1, 2011, at 10:30 AM, Anton Lokhmotov wrote:
>> 
>>> Please find a revised patch attached.  The patch conforms to latest versions
>>> of the OpenCL specification, e.g. accepts both 'const' and 'constant' in
>>> sampler variable declarations.
>>> 
>>> Anton.
>>> 
>>>> Date: Fri, 18 Mar 2011 17:27:33 -0000
>>>> From: "Anton Lokhmotov" <Anton.Lokhmotov at arm.com>
>>>> Subject: [cfe-dev] [PATCH] OpenCL-specific image2d_t,    image3d_t and
>>>>    sampler_t types
>>>> To: <cfe-dev at cs.uiuc.edu>
>>>> Message-ID: <000101cbe591$c4771bf0$4d6553d0$@Lokhmotov at arm.com>
>>>> Content-Type: text/plain; charset="windows-1252"
>>>> 
>>>> We have implemented the OpenCL-specific image2d_t, image3d_t and
>>>> sampler_t types as a separate type OpenCLOtherType, unlike in Tanya's 
>>>> patch [1].  The OpenCL event_t will be supported by OpenCLOtherType as
>>> well.
>>>> 
>>>> The OpenCL-specific types have many semantic restrictions (e.g. see [2]
>>>> for restrictions on the sampler_t type).  We will supply shortly semantic
>>>> checks in a separate patch (or update this one), as well as tests.
>>>> 
>>>> Please note that we assume support for keywords as in our previous
>>>> patch [3].  We will revise the patch once Peter's changes [4] are merged 
>>>> into the trunk.
>>>> 
>>>> Please review.
>>>> 
>>>> Anton.
>>>> 
>>>> [1] Tanya,
>>> http://lists.cs.uiuc.edu/pipermail/cfe-dev/2011-March/013865.html
>>>> [2] Anton,
>>> http://lists.cs.uiuc.edu/pipermail/cfe-dev/2011-March/014118.html
>>>> [3] Anton,
>>> http://lists.cs.uiuc.edu/pipermail/cfe-dev/2011-February/013463.html
>>>> [4] Peter,
>>> http://lists.cs.uiuc.edu/pipermail/cfe-dev/2011-March/013921.html<00006-image-sampler.patch>_______________________________________________
>>> cfe-dev mailing list
>>> cfe-dev at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>> 
>