[cfe-dev] [PATCH] plugin problem on Windows

[John Thompson]

Hi Argyrios,

I've attached a couple of patches for a dumbed-down plugin registration
mechanism, for review.

The cpluginreg patch has most of it for the Clang side.

The lpluginreg patch, for the LLVM side, just adds a couple of preprocessor
symbols for wrapping the DLL imports/exports for Windows.  I wasn't really
sure where to put them, as there doesn't seem to be a common header always
included.  Because they might be involved in the DLL work I plan to do next,
it seemed to make sense to put them in the LLVM side for now.  Let me know
if there is a better place.

I tested this on both Windows and Linux with the print-fns plugin.

-John

On Wed, Apr 6, 2011 at 2:19 PM, Argyrios Kyrtzidis <kyrtzidis at apple.com>wrote:

>   On Apr 6, 2011, at 11:54 AM, John Thompson wrote:
>
>
> Argyrios,
>
>
>> Well your patch pokes at and exposes, IMO, implementation details of
>> Registry; it doesn't seem the right way to go about it..
>>
>
> Okay.  Would you like me to have a go at it, or were you thinking to do it?
>
>
> Please have a go, you'll be able to make sure that it works on Windows,
> unlike if I try.
>
>
> Thanks.
>
> -John
>
> --
> John Thompson
> John.Thompson.JTSoftware at gmail.com
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
>
>


-- 
John Thompson
John.Thompson.JTSoftware at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110407/077e1ffa/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lpluginreg.patch
Type: application/octet-stream
Size: 851 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110407/077e1ffa/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cpluginreg.patch
Type: application/octet-stream
Size: 5623 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110407/077e1ffa/attachment-0001.obj>