[cfe-dev] patch: stylistic improvements to SValBuilder

[Ted Kremenek]

On Apr 3, 2011, at 10:50 AM, Zhanyong Wan (λx.x x) wrote:

> 2011/4/2 Thiago Farina <tfransosi at gmail.com>:
>> 2011/2/28 Zhanyong Wan (λx.x x) <wan at google.com>:
>>> Hi Ted,
>>> 
>>> I have uploaded a patch to http://codereview.appspot.com/4241044,
>>> which hopefully improves the coding style in SValBuilder.  It:
>>> 
>>> - makes all function parameter names start with a lower case letter
>>> for consistency and distinction from member variables.
>>> - avoids abbreviations in function parameter names.
>>> 
>> 
>> Is this defined in the style guide? If not, could you add?
> 
> The first isn't but the second is.
> 
> I tried to add the first to the guide but Chris decided that we don't
> want to require that for the entire LLVM codebase yet.

I do want this convention, however, to gradually be enforced for all of the static analyzer code.