[cfe-dev] patch: refactoring AddStmtChoice

[Zhanyong Wan (λx.x x)]

Thanks for the review!  Committed.

On Tue, Nov 23, 2010 at 5:33 PM, Ted Kremenek <kremenek at apple.com> wrote:
> Looks fantastic.  Please apply.
>
> On Nov 23, 2010, at 5:23 PM, Zhanyong Wan (λx.x x) wrote:
>
>> Hi Ted,
>>
>> I have a patch that refactors class AddStmtChoice to make it easier to
>> use.  Please see http://codereview.appspot.com/3295041
>>
>> The idea is that this class actually represents *two* orthogonal
>> concerns.  By adding methods to manipulate one concern without
>> affecting the other, we allow the call sites to only specify the bit
>> of information they care about -- this makes the code more declarative
>> and simpler.
>>
>> I also added your explanation on how this class works as comments.  Thanks,
>>
>> --
>> Zhanyong
>
>



-- 
Zhanyong