[cfe-dev] questions on the LLVM coding standards

Zhanyong Wan (λx.x x) wan at google.com
Wed Nov 17 11:53:24 PST 2010


On Wed, Nov 17, 2010 at 11:49 AM, Chris Lattner <clattner at apple.com> wrote:
>
> On Nov 16, 2010, at 3:32 PM, Zhanyong Wan (λx.x x) wrote:
>>>
>>> It is not "necessary", in that it doesn't affect the semantics of the program.  It is better that putting the entire body of the .cpp file in "namespace llvm {" because it reduces nesting and interoperates better with IDEs that like to indent according to braces.
>>
>> I see.  It would be nice to add this rationale to the page.  Although
>> I can also understand it if you don't want to bloat it...
>
> Sure, done in r119544.  I don't know if it is more or less confusing, but there ya go :)
>
>> Have you seen my patch that fixes some typos and formatting nits in
>> the coding standards?  It should be in your inbox waiting for your
>> review.  Thanks,
>
> Yep, applied, thanks!

Thanks for doing both, Chris!
-- 
Zhanyong




More information about the cfe-dev mailing list