[cfe-dev] SourceRange for QualifiedTypeLoc

Abramo Bagnara abramo.bagnara at gmail.com
Thu May 20 06:05:36 PDT 2010


Il 20/05/2010 12:11, Abramo Bagnara ha scritto:
> Il 19/05/2010 21:43, John McCall ha scritto:
>>
>> ...also, the names aren't great;  I wouldn't object to a couple of renames:
>>   getSourceRange -> getLocalSourceRange
>>   getFullSourceRange -> getSourceRange
> 
> Done in r104220.

I'm under the impression that *every* use of getLocalSourceRange outside
TypeLoc.hh and TypeLoc.cpp is bogus...

My proposal is:

- add TypeLoc::getBeginLoc() and TypeLoc::getEndLoc() with a possibily
specialized implementation (at least for Elaborated and DependendentName
and QualifiedTypeLoc)

- implement getSourceRange() using the two just added method

- transform getLocalSourceRange().getBegin() in getBeginLoc()

- transform getLocalSourceRange().getEnd() in getEndLoc()

- transform getLocalSourceRange() in getSourceRange()

- move getLocalSourceRange() to protected area.




More information about the cfe-dev mailing list