[cfe-dev] PR5478 Patch - unexpected function pointer in argument diagnostic improvement

[Samuel Harrington]

On Tue, Mar 30, 2010 at 4:13 PM, John McCall <rjmccall at apple.com> wrote:
> On Mar 30, 2010, at 2:56 PM, Samuel Harrington wrote:
>>
>> Ok, done. Please note that the diagnostic for this case now points to
>> the call instead of the declaration of the function, so the code
>> modification hint can be displayed. For this case, I think this is
>> more understandable.
>
> Please don't do this.  Consistency is important, and so is knowing what candidate the note is referring to.  The code modification hint isn't worth losing that (not that you should remove the hint;  it just won't get displayed by the console client).
>
> John.


Ok, that makes sense. I've attached a new patch. Thanks for reviewing!

Thanks,
Sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: func_as_arg_v3.patch
Type: application/octet-stream
Size: 5345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20100330/0a47446d/attachment.obj>