[cfe-dev] Analyzer: Extract region-walking behavior from CallAndMessageChecker

[Zhongxing Xu]

On Tue, Jun 29, 2010 at 6:54 AM, Ted Kremenek <kremenek at apple.com> wrote:
> I understand your point, but I think I still strongly disagree here.
>
> I'm fine with the checker behavior being controlled by an option, but just having the code go in as is (with these obvious algorithmic performance issues) sets a bad precedent for how we think things should "get done" in the analyzer.  The current check should probably be changed as well because of this reason.
>
> Implementing this the right way involves extending StoreManager with the right APIs so that the query can get executed efficiently.  We shouldn't just hack things into the analyzer because it is immediately convenient, especially when doing it right isn't necessarily that hard.  Having good design and thinking these issues out at the appropriate times is well worth it in the long run, as hacks have a way of piling up.

Make sense.