[cfe-dev] [patch] Microsoft Extension - #pragma message

[Michael Spencer]

On Wed, Jun 23, 2010 at 1:52 AM, Chris Lattner <clattner at apple.com> wrote:
> Hi Michael,
>
> Thanks for working on this.  This looks good with two minor changes:
>
> 1) please drop the testcase into the Lex directory instead of making a new MicrosoftExtensions directory for it.  The MS testcases can be found by grepping for ms-extensions.
>
> 2) Though it almost certainly isn't a performance issue, for code cleanliness, please change "PragmaMessage" to take a StringRef by value instead of taking a std::string.  This will allow PP::HandlePragmaMessage to pass the string directly from the literal parser instead of indirecting through the std::string.
>
> Thanks again,
>
> -Chris

Changes made and new patch attached. Would you like those same changes
made to PragmaComment? That's the style I followed for PragmaMessage.

- Michael Spencer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pragma-message.patch
Type: application/octet-stream
Size: 8482 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20100624/b987c22c/attachment.obj>