[cfe-dev] Assertion on valid use of highlighting whitespace

Douglas Gregor dgregor at apple.com
Mon Jun 21 11:43:46 PDT 2010


On Jun 21, 2010, at 11:36 AM, Chris Lattner wrote:

> 
> On Jun 21, 2010, at 11:17 AM, Tom Care wrote:
> 
>> Hi Chris,
>> 
>> Works great except now I'm getting off by 1 problems at the end of the string:
>> 
>> /tmp/fixit.c:41:12: warning: flag '0' is ignored when flag '-' is present
>>   printf("%0-f", 1.23);
>>           ~^~
>> 
>> Should my SourceLocation for the end byte be pointing to the 'f' or the '"'? It's currently pointing to the 'f'.
> 
> You tell me.  Right now, the ranges are set up for half open ranges [start, end).  If you want fully inclusive ranges [start, end] I can make that work, just let me know what feels most natural from a client standpoint.

Please keep it as half-open!

	- Doug

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20100621/17a5be2d/attachment.html>


More information about the cfe-dev mailing list