[cfe-dev] improve attributes handling in clang

Eric Christopher echristo at apple.com
Thu Dec 2 11:29:31 PST 2010


On Dec 2, 2010, at 2:11 AM, Sean Hunt wrote:

> On 10-12-02 04:55 AM, Michael Han wrote:
>> I think one improvement would be to move the AttributeList::Kind in Sema into td file so codes like AttributeList::getKind can be generated through tblgen. If this is done then adding an implementation defined (gnu style) attribute would only require user modify the attribute table definition file (with user's code to handle attributes in Sema but that's not part of infrastructure anyway). Currently when we add our attributes we need to visit several places in Sema to fix the boilerplate code.
>> 
>> Cheers
>> ~Michael
> 
> My intent is to remove AttributeList entirely. Especially now that we 
> have removed the Parser/Sema barrier, it makes no sense to have two 
> separate data structures for the same thing.

Yes please :)

That felt odd yesterday. I'd thrown it on my todo list not knowing if you were coming back. Now that you are, thanks!

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20101202/c89c1ae0/attachment.html>


More information about the cfe-dev mailing list