[cfe-dev] patch: add friend information for class types and access modifiers for methods to debug info

[Alexander Herz]

Any update on whether the corrected version of the patch will be accepted?

Thx.
Alex

On 08/12/2010 07:21 PM, Devang Patel wrote:
> Hi Alex,
>
> I'll apply these patches once following issues are resolved. I see few 
> tabs sneaked into diffs. clang and llvm code is tabs free. Few other 
> comments...
>
>
>     -  // Static methods do not need "this" pointer argument.
>     -  if (Method->isStatic())
>     -    return FnTy;
>
>
> Why are you removing this check ? All the changes 
> to getOrCreateMethodType() function are unnecessary and not related to 
> this patch.
>
>
>
>     +/// CollectCXXFriends - A helper function to collect debug info for
>     +/// C++ base classes. This is used while creating debug info
>     entry for
>     +/// a Record.
>     +void CGDebugInfo::
>     +CollectCXXFriends(const CXXRecordDecl *RD, llvm::DIFile Unit,
>     +                llvm::SmallVectorImpl<llvm::DIDescriptor> &EltTys,
>     +                llvm::DICompositeType &RecordTy) {
>     +
>     +  for (CXXRecordDecl::friend_iterator BI =  RD->friend_begin(),
>     +         BE = RD->friend_end(); BI != BE; ++BI) {
>     +    unsigned BFlags = 0;
>
>
> This BFlags is never assigned any other value. Intentional ?
>
> llvm diffs looks fine.
> Thanks for working on this.
> -
> Devang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20100823/69356dda/attachment.html>