[cfe-dev] Target.cpp

[Daniel Dunbar]

Hi John,

Thanks for the refactoring, it looks good to me, I applied as r82621.

On Tue, Sep 22, 2009 at 11:21 PM, John Thompson
<john.thompson.jtsoftware at gmail.com> wrote:
> Hi Daniel,
> Sorry for the duplicate email, I keep forgetting to pay attention to the
> return address.
> I've redone the patch without the Triple changes.  The current triple
> mechanism seems a bit out-of-date, as the correct triple for 64-bit Windows
> appears to be "x86_64-pc-win32", but we can leave that for whoever owns it.

Ok.

> At some point, if Clang wants to be it's own environment on Windows, we'll
> probably have to revise this a bit to be able to do something other than
> default to Visual Studio for the "win32" OS-type, but this is probably good
> enough for now.

Yeah, we will probably want to go a long time before we care about
this. Adoption means being compatible with the existing environment,
as painful as it may be.

> Thanks for dealing with this for me.
>
> -John
>
> P.S.  I added an empty define for __declspec.  Is this all that's needed?

Dunno...

By the way, I still don't have all my local patches in for testing on
Windows (there are basically 3, one to add count + not to
test/Scripts, one to add my local search headers, and one to hack
around stdint.h), but the current number of test failures is ~60,
which isn't too bad. A lot of the remaining ones are STL iterator
pickyness which should be easy to eliminate if someone sits down to
work through them.

Also, what happened with your patch to add MSVC search paths in a more
principled fashion? In my fuzzy memory I thought it had gone in, but I
didn't actually see it in the source.

 - Daniel