[cfe-dev] Windows patches

[John Thompson]

Thanks, Mike.

Can you give me some pointers on how to do a platform-specific file?  I
don't see any examples, and I don't know cmake.  For example, have a
"windows" subdirectory, and some conditional in the CMakeLists.txt file?
And how to make sure make doesn't pick up the file.

I figure the Basic library might be a good place for it.

Note that I found some errors in the registry part of it, and I'm
experimenting with getting the windows.h include to work.

> Aside from that, I think the rest of the patch has now been checked in.
If there are any pieces I missed, please svn up, and send in what's
missing.  And welcome.

You got them all, thanks!
-John
On Thu, Oct 8, 2009 at 4:33 PM, Mike Stump <mrs at apple.com> wrote:

> On Oct 8, 2009, at 12:08 PM, John Thompson wrote:
>
>>
>> include/clang/Frontend/InitHeaderSearch.h:
>> lib/Frontend/InitHeaderSearch.cpp:
>> tools/clang-cc/clang-cc.cpp:
>>
>> This is a slight revision to the patch I posted yesterday to have the
>> default include path code use the target triple, as the line numbers were
>> off due to some other changes.  It also sets up include paths for VC++ and
>> Cygwin headers, along with the existing MinGW headers, plus the newer 4.4.0
>> version.  Note that running the tests with the MinGW headers results in 40
>> or more failed tests.  Currently, with this patch, only 23 tests are failing
>> with the VC++ headers.  I did leave in some disabled code regarding the
>> question I posted yesterday about including windows.h for the registry
>> stuff.
>>
>
> I've checked this in, along with some minor whitespacing issues.  Please
> keep lines to 80 columns.  Also, be sure to detab the files as well.  In
> some editors, there is a setting to avoid the use of hard tabs.
>
> I think the windows code should be boosted out to a new file, and hidden
> away from us mere mortals.  In general #if in files is to be discouraged.
>



-- 
John Thompson
John.Thompson.JTSoftware at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20091008/daca4dc9/attachment.html>