[cfe-dev] lifetime of conditional temporaries

Victor Zverovich victor.zverovich at googlemail.com
Wed Nov 18 07:20:17 PST 2009


Hi Anders,

Thanks for the review.
I have moved the new tests into conditional-temporaries.cpp as you
suggested.
The patches are attached.

Regards,
Victor

2009/11/18 Anders Carlsson <andersca at mac.com>

> Hi Victor,
>
> the patches look great! Thanks for fixing this :)
>
> One small comment - could you move the conditional temporaries tests into a
> separate file? You could call it conditional-temporaries.cpp
>
> Thanks,
> Anders
>
> 17 nov 2009 kl. 23.20 skrev Victor Zverovich:
>
> The first patch (cond-temp-test.patch) adds 3 new test cases that check the
> lifetime of conditional temporaries.
> The second patch (cond-temp.patch) fixes the bug making the new test cases
> pass.
>
> Victor
>
> 2009/11/17 Victor Zverovich <victor.zverovich at googlemail.com>
>
>> I submitted it here http://llvm.org/bugs/show_bug.cgi?id=5539 so that it
>> is not lost until I come up with a fix.
>>
>> Victor
>>
>> 2009/11/17 Anders Carlsson <andersca at mac.com>
>>
>> 17 nov 2009 kl. 04.44 skrev Victor Zverovich:
>>>
>>> > Dear all
>>> >
>>> > The same applies to && and || operators. Is this intended or needs to
>>> be fixed in clang?
>>> > In the latter case and if nobody is already working on it I can try
>>> fixing it.
>>> >
>>>
>>> Hi Victor,
>>>
>>> this should work. Please file a bug.
>>>
>>> Anders
>>>
>>> > Best regards,
>>> > Victor
>>> >
>>> > _______________________________________________
>>> > cfe-dev mailing list
>>> > cfe-dev at cs.uiuc.edu
>>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>>>
>>>
>>
> <cond-temp-test.patch><cond-temp.patch>
> _______________________________________________
>
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20091118/116f2e2d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cond-temp.patch
Type: application/octet-stream
Size: 6874 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20091118/116f2e2d/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cond-temp-test.patch
Type: application/octet-stream
Size: 797 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20091118/116f2e2d/attachment-0001.obj>


More information about the cfe-dev mailing list