[cfe-dev] Newly failing tests on Windows, assert in PCHReader.cpp, new argument

[John Thompson]

Then may I check in the enclosed changes?

Of question might be the changes to SemaCXX/new-delete.cpp, where I needed
to change the type to something different from size_t for both Windows
(unsigned int) and Unix (unsigned long), which I think is int.  But if there
is a platform using "int" for size_t, this will be a problem.

Thanks.  (Sorry for the dup, Fariborz.)

-John

On Wed, Nov 11, 2009 at 12:57 PM, Fariborz Jahanian <fjahanian at apple.com>wrote:

> We already use stddef.h for such types as ptrdiff_t. Let's do it for size_t
> as well.
>
> - Fariborz
>
>   On Nov 11, 2009, at 12:31 PM, John Thompson wrote:
>
>   30 tests are failing on Windows, 27 newly since Monday.
>
> 25 of them are due to an assert at line 172 in PCHReader.cpp.
>
> The problem is that the file path appended to the Predefines has been
> converted to use double-'\', whereas the path in OriginalFileName used
> single '/'.
>
> I'm not sure which side to change.
>
> The other is in CodeGenCXX/new-operator-phi.cpp:
>
> 1>  Line 4: 'operator new' takes type size_t ('unsigned int') as first
> parameter
> I'm not sure what you want to do here, whether to change it to use size_t
> and to include stddef.h, or put in a platform conditional.
> -John
>
> --
> John Thompson
> John.Thompson.JTSoftware at gmail.com
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
>
>


-- 
John Thompson
John.Thompson.JTSoftware at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20091111/bc7d462c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: newargtype.patch
Type: application/octet-stream
Size: 1824 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20091111/bc7d462c/attachment.obj>