[cfe-dev] Diagnostics are now TableGenerated

[Douglas Gregor]

On Mar 14, 2009, at 4:28 AM, Sebastian Redl wrote:
> Once the llvm.org server comes back up, I'll commit the changes that
> switch Clang from using .def files for the diagnostics to .td tablegen
> files. It compiles, all tests pass, and there aren't any spurious
> rebuilds. (Except perhaps for CMake users.)

We had a little bit of trouble here, since the original change broke  
CMake and out-of-source makefile builds, so Sebastian reverted his  
commit.

Now, I've just committed r67058, which introduces the build-system  
changes from Sebastian's work with fixes for CMake and out-of-source  
makefile builds but without actually eliminating the ".def" files. We  
can use this current state to shake out any remaining build system  
issues before we make the switch.

The attached patch contains the changes needed to switch from using  
the existing ".def" files to the ".inc" files now generated by the  
build system. Apply this, then remove include/clang/Basic/ 
Diagnostic*Kinds.def, and you'll be using the new TableGen-based system.

I don't have access to Visual Studio, but I'd appreciate if someone  
could do a CMake + Visual Studio build with r67058 (and, optionally,  
the attached patch) to see if my CMake-fu works.

	- Doug


-------------- next part --------------
A non-text attachment was scrubbed...
Name: warnings-switchover.patch
Type: application/octet-stream
Size: 6731 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20090316/e4cb4b2e/attachment.obj>