[cfe-dev] Adding access to array size expressions in ConstantArrayType.

Enea Zaffanella zaffanella at cs.unipr.it
Mon Jun 15 10:05:53 PDT 2009

Enea Zaffanella wrote:
> Eli Friedman wrote:
>> I would prefer that the expr is always passed in explicitly; in
>> addition to getting rid of two confusingly similar prototypes, it'll
>> make it easier to audit the various callers in the patch.  (There's at
>> least one caller which I know isn't doing the right thing here.)
>> -Eli
> OK, we will remove the old constructor and add the missing null pointer 
> to the other calls. Out of curiosity, since we went through *all* of the 
> calls of the old constructor, which is the specific call of 
> getConstantArrayType that you say we are mishandling?
> Cheers,
> Abramo Bagnara and Enea Zaffanella.

Here is the alternative version of the patch where the expression 
pointer is always passed explicitly. Please, let us know of this is ok.

Enea Zaffanella
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ConstantArrayType-ExplicitConstructor.diff
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20090615/d65deacc/attachment.ksh>

More information about the cfe-dev mailing list