[cfe-dev] PCHReader: Header search info and FileManager::NextFileUID
dgregor at apple.com
Sun Jun 7 23:25:45 PDT 2009
On Jun 7, 2009, at 10:48 PM, Zhongxing Xu wrote:
> 2009/6/8 Zhongxing Xu <xuzhongxing at gmail.com>:
>> After HeaderSearchInfo is recovered in
>> PCHReader::ReadSourceManagerBlock(), we actually have used some UIDs
>> (recorded by NumHeaderInfos). But at this time the NextFileUID in
>> FileManager is still 0. Call to FileManager::getFile() could use that
>> FileUID for a different file than the header in HeaderSearch. Would
>> this inconsistency cause problems?
> After reading some more code, my understanding is that all file source
> locations are then preloaded and FileManager is restored to the
> appropriate state.
Yes, we preload all file source locations. We may be able to decrease
PCH load times slightly by not preloading them, but it's not something
that ever came up in a profile so I doubt it's important.
More information about the cfe-dev