[cfe-dev] Patch for UCNs in string literals

Eli Friedman eli.friedman at gmail.com
Sat Jul 4 23:57:35 PDT 2009

On Sat, Jul 4, 2009 at 10:16 PM, James Porter<porterj at alum.rit.edu> wrote:
> Eli Friedman wrote:
>> Please just include the subset of tests that currently passes; we can
>> add additional tests as the issues get fixed.
> I was under the impression based on the website that XFAIL'd tests were
> encouraged:
>     http://clang.llvm.org/OpenProjects.html
>     "Pick a paragraph, write a few tests, and see if they work! Even if
>     they don't we'd still like the new tests (with XFAIL'd) so that we
>     know what to fix."

A patch should be accompanied by a non-XFAIL'd test for each thing it
fixes; otherwise, the tests won't detect regressions.  I haven't
thought through what that means for the C++ tests; perhaps splitting
them into p2a/p2b/p2c/etc. would be appropriate.


More information about the cfe-dev mailing list