[cfe-dev] Adding access to array size expressions in ConstantArrayType.

Enea Zaffanella zaffanella at cs.unipr.it
Sat Jul 4 00:31:12 PDT 2009

Enea Zaffanella wrote:
> Eli Friedman wrote:
>> On Tue, Jun 30, 2009 at 12:35 PM, Enea 
>> Zaffanella<zaffanella at cs.unipr.it> wrote:
> [...]
>> Unlike the other array types you're adding Brackets to,
>> IncompleteArrayType gets canonicalized; we don't want a source range
>> on a canonical IncompleteArrayType, and we don't want to end up with
>> the wrong SourceRange on a non-canonical IncompleteArrayType.  It's a
>> little tricky, so if the issues I'm talking about aren't obvious, I'd
>> suggest skipping adding the bracket locations to IncompleteArrayType
>> for now.
>> Otherwise, this is looking good!
>> -Eli
> OK, here is the patch revised along your suggestions.
> Enea.

I got no feedback on my last revision of the patch and it seems that the 
patch was not applied. Is there something wrong with it? Or should I 
just wait a bit more?


More information about the cfe-dev mailing list