[cfe-dev] Tiny patch for va_list definition on x86-64 target

Eli Friedman eli.friedman at gmail.com
Thu Jul 2 12:40:20 PDT 2009

On Thu, Jul 2, 2009 at 9:22 AM, Abramo Bagnara<abramobagnara at tin.it> wrote:
> Here attached you find a patch that add and intermediate typedef between
> struct __va_list_tag and __builtin_va_list on x86-64.
> This patch is fundamental in our project to recompile with gcc a pretty
> printed output of clang AST.

Hmm... if the user never writes "struct __va_list_tag" explicitly, it
should never show up in the pretty-printed output.  In what situations
is this an issue?

> With this patch, instead, va_list decays to __va_list_tag_t* that is
> easily mappable to gcc internal type for va_list.

Why __va_list_tag_t instead of __va_list_tag (which is what gcc uses)?

Otherwise, the patch looks fine.


More information about the cfe-dev mailing list