[cfe-dev] MSVC Ownership.h patch

Douglas Gregor dgregor at apple.com
Wed Jul 1 08:13:25 PDT 2009

On Jul 1, 2009, at 3:38 AM, AlisdairM wrote:

>> -----Original Message-----
>> From: Chris Lattner [mailto:clattner at apple.com]
>> Sent: 25 June 2009 17:17
>> To: AlisdairM (public)
>> Cc: 'Douglas Gregor'; cfe-dev at cs.uiuc.edu
>> Subject: Re: [cfe-dev] MSVC Ownership.h patch
>> We usually use "#ifdef _MSC_VER" to detect microsoft compilers.  If
>> you want to detect the windows platform, use #ifdef LLVM_ON_WIN32
> Thanks.
> Updated patch attached that unconditionally tests for Microsoft  
> compilers.
> I have taken the lead from Olaf to move the cast logic into a separate
> function, but retain the compiler checks.

Patch committed. Thanks, Alisdair!

	- Doug

More information about the cfe-dev mailing list