[cfe-dev] Adding access to array size expressions in ConstantArrayType.

Enea Zaffanella zaffanella at cs.unipr.it
Wed Jul 1 01:19:15 PDT 2009

Eli Friedman wrote:
> On Tue, Jun 30, 2009 at 12:35 PM, Enea Zaffanella<zaffanella at cs.unipr.it> wrote:


> Unlike the other array types you're adding Brackets to,
> IncompleteArrayType gets canonicalized; we don't want a source range
> on a canonical IncompleteArrayType, and we don't want to end up with
> the wrong SourceRange on a non-canonical IncompleteArrayType.  It's a
> little tricky, so if the issues I'm talking about aren't obvious, I'd
> suggest skipping adding the bracket locations to IncompleteArrayType
> for now.
> Otherwise, this is looking good!
> -Eli

OK, here is the patch revised along your suggestions.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ConstantArrayWithExprAndBrackets-Revised.patch
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20090701/f8f93554/attachment.ksh>

More information about the cfe-dev mailing list