[cfe-dev] Fixing selector types on the GNU runtime

Chris Lattner clattner at apple.com
Mon Jan 19 13:29:38 PST 2009


On Jan 19, 2009, at 1:25 PM, Mike Stump wrote:

> On Jan 18, 2009, at 3:01 PM, David Chisnall wrote:
>> NULL is #defined as 0 for C++ on FreeBSD.
>
> This is wrong.  If you're using a recent g++ based compiler, NULL
> should be __null in g++.  :-)
>
>> I get missing sentinels in a huge numbers of missing sentinel errors
>> when
>> building LLVM.
>
> And do they go away if you have NULL defined correctly?

I agree with Mike here.  FreeBSD should be using __null or 0L.  I  
don't think we should switch CGObjCGNU to using a different idiom than  
the rest of the code base, and I don't want to change the entire LLVM  
world to avoid NULL in varargs.

If FreeBSD headers are broken and they are unwilling to fix it, we can  
probably do a hack for FreeBSD in the makefiles.

-Chris




More information about the cfe-dev mailing list