[cfe-dev] CharacterLiteral get/set location.

Gordon Henriksen gordonhenriksen at me.com
Mon Aug 24 09:59:50 PDT 2009


On Aug 24, 2009, at 12:43, Chris Lattner wrote:

> On Aug 24, 2009, at 5:46 AM, Enea Zaffanella wrote:
>
>> Class CharacterLiteral has the following public methods, which are  
>> inconsistently named:
>>
>> SourceLocation getLoc() const { return Loc; }
>> void setLocation(SourceLocation Location) { Loc = Location; }
>>
>> The attached patch makes these names consistent.
>
> Looks great, please attach the patch as an attachment (instead of  
> inline) to make it easier to apply. Thanks!

See directions 'For Thuderbird users' here:

http://llvm.org/docs/DeveloperPolicy.html#patches

— Gordon



More information about the cfe-dev mailing list