[cfe-dev] invalid Assert in Lex/LiteralSupport.cpp?

[Sanjiv.Gupta at microchip.com]

CharLiteralParser::CharLiteralParser(const char *begin, const char *end,

                                     SourceLocation Loc, Preprocessor
&PP) {

  // At this point we know that the character matches the regex
"L?'.*'".

 

  ....

 

  // FIXME: This assumes that 'int' is 32-bits in overflow calculation,
and the

  // size of "value".

  assert(PP.getTargetInfo().getIntWidth() == 32 &&

         "Assumes sizeof(int) == 4 for now");

 

For PIC16, "int" is 16.  

Should this assert be rather 

 

assert(PP.getTargetInfo().getIntWidth() <= 32 &&

         "Assumes sizeof(int) <= 4 for now");

 

 

- Sanjiv

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20090413/d133cb28/attachment.html>