[cfe-dev] UTF16 CFString

[Jean-Daniel Dupas]

Just two suggestions to help in adding UTF16 support for CFString /  
NSString.

I think llvm::Constant *GetAddrOfConstantCFString can be changed to  
take s StringLiteral as argument instead of std::string.
So, the UTF16 promotion can be implemented here and works work both  
__builtin_cfstring and objc literal strings.

The other suggestion it about the containsNonAscii() method. I think  
it should be containsNonAsciiOrNull(), as GCC promote CF / Obj-C  
strings to UTF16 for ascii string that contains a NULL character too.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cfutf.diff
Type: application/octet-stream
Size: 3359 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20090401/f2887e1d/attachment.obj>
-------------- next part --------------