[cfe-dev] cast.diff [ Re: Continuing Adventures with Objective-C]

[David Chisnall]

On 16 May 2008, at 17:54, Devang Patel wrote:

>>
>> Index: lib/CodeGen/CodeGenFunction.h
>> ===================================================================
>> --- lib/CodeGen/CodeGenFunction.h       (revision 51026)
>> +++ lib/CodeGen/CodeGenFunction.h       (working copy)
>> @@ -67,7 +67,9 @@
>>   class ChooseExpr;
>>   class PreDefinedExpr;
>>   class ObjCStringLiteral;
>> +  class ObjCSelectorExpr;
>>   class ObjCIvarRefExpr;
>> +  class ObjCMessageExpr;
>>   class MemberExpr;
>>
>>   class VarDecl;
>> @@ -296,11 +298,15 @@
>
> Do you need this ? I don't see any use in this patch.

Ooops, those should have been in a different diff (it's hard to keep  
track of which bits depend on which other bits).  These are needed  
here for the declaration of EmitObjCSelectorExpr() and  
EmitObjCMessageExpr().  It seems I messed up quite badly splitting the  
diff into small parts, since these are used in the code in expr.diff  
and defined in objc.diff.  Sorry.

David