[cfe-dev] wchar printer

[Mike Stump]

On Jun 5, 2008, at 12:50 AM, Bill Wendling wrote:
> On Jun 4, 2008, at 6:40 PM, Mike Stump wrote:
>
>> This removes one FIXME by arranging for wide characters to be  
>> printed correctly.
>>
> +  CharacterLiteral(unsigned value, bool iswide, QualType type,  
> SourceLocation l)
> +    : Expr(CharacterLiteralClass, type), Value(value),  
> IsWide(iswide), Loc(l) {
>
> You need to have "IsWide" the last in the initialization list.

Done.

>
> void CharacterLiteral::EmitImpl(Serializer& S) const {
>   S.Emit(Value);
> +  S.EmitBool(IsWide);
>   S.Emit(Loc);
>   S.Emit(getType());
> }
>
> Why not emit in the same order that the variables are defined in the  
> class?

Done.

> Same below:

Done.


Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: wchar-1a.patch
Type: application/octet-stream
Size: 2567 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20080605/10b6d160/attachment.obj>