[cfe-dev] Member expression returns type with wrong qualifiers

Steve Naroff snaroff at apple.com
Wed Feb 6 09:15:00 PST 2008


On Feb 6, 2008, at 12:20 AM, Eli Friedman wrote:

> On Feb 4, 2008 5:54 PM, Steve Naroff <snaroff at apple.com> wrote:
>> I think it would be a bit cleaner to fold the getTypeForMemberExpr()
>> logic into Sema::ActOnMemberReferenceExpr() and pass in the derived
>> type explicitly (just add an argument to the constructor). Passing  
>> the
>> type in explicitly is more consistent with all the other expr AST's.
>
> So, more like the attached?
>

Exactly. Looks great.

Please add a test for this bug/patch and commit.

Thanks,

snaroff

> -Eli
> <memberexprfix.txt>




More information about the cfe-dev mailing list