[cfe-dev] move HeaderSearch setup to Driver lib
kremenek at apple.com
Thu Aug 21 16:44:28 PDT 2008
On Aug 21, 2008, at 4:16 PM, Nico Weber wrote:
>>> Is the topic related thing on the todo list ?
>>> It would let users to build a driver more easily.
>> I agree. The attached patch moves most of the HeaderSearch setup to
>> libDriver. Comments?
> So, since no-one objects, can I check this in? :-P
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
Functionally the patch looks good to me. Could you add doxygen
comments to the class InitHeaderSearch to describe what it does? From
the way it is used, it is clearly a "builder object" that is used to
populate data into a HeaderSearch object. It would be great if the
doxygen comments above that class basically just said that. Other
than that, it looks good to apply (assuming all tests pass).
More information about the cfe-dev