[cfe-dev] GotoStmt::getSourceRange, bug?

Ted Kremenek kremenek at apple.com
Thu Sep 6 10:13:52 PDT 2007


On Sep 6, 2007, at 9:58 AM, Steve Naroff wrote:

> Not currently. It looks like we need to add a "LabelLoc" to the AST  
> (this is already passed into the actions, so it's trivial to do).  
> Make sense?
>
> Thanks for finding this,

Cool.  I've committed a patch.  I'm terribly familiar with the  
mechanics of SourceLocations, so if someone could audit the patch that  
would be great.

In particular, I'm not so certain about the following line in  
GotoStmt:getSourceRange:

   return SourceRange(GotoLoc, LabelLoc);

This extent will only include from the start of the goto statement to  
the start of the label token (and not the end of the label token).  Is  
this what we want?



More information about the cfe-dev mailing list