[cfe-dev] vprintf(3) and "format string is not a string literal"

[Ted Kremenek]

On Dec 17, 2007, at 5:48 AM, Shantonu Sen wrote:

>> Ultimately, we should probably make warnings like these an option.   
>> People can then decide their own policy on when such warnings are  
>> emitted.
>
> How about this:
> $ clang -std=c99 a.c
> a.c:10:23: warning: format string is not a string literal  
> (potentially insecure)
>        ret = vprintf(fmt, ap);
>              ~~~~~~~ ^
> 1 diagnostic generated.
> $ clang -std=c99 a.c -Wno-format-nonliteral
> $
>
> <clang.cpp.diff>

This looks great to me.  I'll go and apply the patch.