<div dir="ltr">Ah, no worries - thanks for being aware of it & I get we're all having some teething problems with github, etc.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jan 17, 2024 at 3:36 PM Erich Keane <<a href="mailto:ekeane@nvidia.com">ekeane@nvidia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg-2933971423061011906">
<div dir="ltr">
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
yeah, something weird happened with this one that i haven't figured out yet. This was a response to a review comment, and was on the review (and committed as a part of that review!) but somehow I managed to 'recommit' it, not sure how.</div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
So yeah <span id="m_-2933971423061011906🙁">🙁</span> I'm usually better at commit messages, but didn't intend this to be anything but one of many squashed on the PR.<br>
</div>
<div id="m_-2933971423061011906appendonsend"></div>
<hr style="display:inline-block;width:98%">
<div id="m_-2933971423061011906divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>><br>
<b>Sent:</b> Wednesday, January 17, 2024 3:32 PM<br>
<b>To:</b> Erich Keane <<a href="mailto:ekeane@nvidia.com" target="_blank">ekeane@nvidia.com</a>>; <a href="mailto:llvmlistbot@llvm.org" target="_blank">llvmlistbot@llvm.org</a> <<a href="mailto:llvmlistbot@llvm.org" target="_blank">llvmlistbot@llvm.org</a>><br>
<b>Cc:</b> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a> <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>><br>
<b>Subject:</b> Re: [clang] d5000e9 - rename to 'try' isntead of 'Try'x</font>
<div> </div>
</div>
<div>
<table bgcolor="#FFEB9C" border="1">
<tbody>
<tr>
<td><font face="verdana" color="black" size="1"><b>External email: Use caution opening links or attachments</b>
</font></td>
</tr>
</tbody>
</table>
<br>
<div>
<div dir="ltr">Be good to have more description of "why" in commit messages in general (the "what" is provided by the patch itself, especially when it's a small one like this) - I guess this was to match naming conventions, that this file generally already
follows lower-first, etc.</div>
<br>
<div>
<div dir="ltr">On Tue, Jan 16, 2024 at 7:04 AM via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
</div>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Author: erichkeane<br>
Date: 2024-01-16T07:04:28-08:00<br>
New Revision: d5000e9cd95b720fc9082da6cdcdb2c865303dcf<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/d5000e9cd95b720fc9082da6cdcdb2c865303dcf" rel="noreferrer" target="_blank">
https://github.com/llvm/llvm-project/commit/d5000e9cd95b720fc9082da6cdcdb2c865303dcf</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/d5000e9cd95b720fc9082da6cdcdb2c865303dcf.diff" rel="noreferrer" target="_blank">
https://github.com/llvm/llvm-project/commit/d5000e9cd95b720fc9082da6cdcdb2c865303dcf.diff</a><br>
<br>
LOG: rename to 'try' isntead of 'Try'x<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
clang/lib/Parse/ParseOpenACC.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/clang/lib/Parse/ParseOpenACC.cpp b/clang/lib/Parse/ParseOpenACC.cpp<br>
index 018c61de4be369..a5a028e1c6a799 100644<br>
--- a/clang/lib/Parse/ParseOpenACC.cpp<br>
+++ b/clang/lib/Parse/ParseOpenACC.cpp<br>
@@ -183,7 +183,7 @@ bool isTokenIdentifierOrKeyword(Parser &P, Token Tok) {<br>
/// Return 'true' if the special token was matched, false if no special token,<br>
/// or an invalid special token was found.<br>
template <typename DirOrClauseTy><br>
-bool TryParseAndConsumeSpecialTokenKind(Parser &P, OpenACCSpecialTokenKind Kind,<br>
+bool tryParseAndConsumeSpecialTokenKind(Parser &P, OpenACCSpecialTokenKind Kind,<br>
DirOrClauseTy DirOrClause) {<br>
Token IdentTok = P.getCurToken();<br>
// If this is an identifier-like thing followed by ':', it is one of the<br>
@@ -713,7 +713,7 @@ void Parser::ParseOpenACCCacheVarList() {<br>
// The VarList is an optional `readonly:` followed by a list of a variable<br>
// specifications. Consume something that looks like a 'tag', and diagnose if<br>
// it isn't 'readonly'.<br>
- if (TryParseAndConsumeSpecialTokenKind(*this,<br>
+ if (tryParseAndConsumeSpecialTokenKind(*this,<br>
OpenACCSpecialTokenKind::ReadOnly,<br>
OpenACCDirectiveKind::Cache)) {<br>
// FIXME: Record that this is a 'readonly' so that we can use that during<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote>
</div>
</div>
</div>
</div>
</div></blockquote></div>