<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
yeah, something weird happened with this one that i haven't figured out yet. This was a response to a review comment, and was on the review (and committed as a part of that review!) but somehow I managed to 'recommit' it, not sure how.</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
So yeah <span id="🙁">🙁</span> I'm usually better at commit messages, but didn't intend this to be anything but one of many squashed on the PR.<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> David Blaikie <dblaikie@gmail.com><br>
<b>Sent:</b> Wednesday, January 17, 2024 3:32 PM<br>
<b>To:</b> Erich Keane <ekeane@nvidia.com>; llvmlistbot@llvm.org <llvmlistbot@llvm.org><br>
<b>Cc:</b> cfe-commits@lists.llvm.org <cfe-commits@lists.llvm.org><br>
<b>Subject:</b> Re: [clang] d5000e9 - rename to 'try' isntead of 'Try'x</font>
<div> </div>
</div>
<div>
<table bgcolor="#FFEB9C" border="1">
<tbody>
<tr>
<td><font face="verdana" color="black" size="1"><b>External email: Use caution opening links or attachments</b>
</font></td>
</tr>
</tbody>
</table>
<br>
<div>
<div dir="ltr">Be good to have more description of "why" in commit messages in general (the "what" is provided by the patch itself, especially when it's a small one like this) - I guess this was to match naming conventions, that this file generally already
follows lower-first, etc.</div>
<br>
<div class="x_gmail_quote">
<div dir="ltr" class="x_gmail_attr">On Tue, Jan 16, 2024 at 7:04 AM via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
</div>
<blockquote class="x_gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<br>
Author: erichkeane<br>
Date: 2024-01-16T07:04:28-08:00<br>
New Revision: d5000e9cd95b720fc9082da6cdcdb2c865303dcf<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/d5000e9cd95b720fc9082da6cdcdb2c865303dcf" originalsrc="https://github.com/llvm/llvm-project/commit/d5000e9cd95b720fc9082da6cdcdb2c865303dcf" shash="Jcz2zpAlVbgtCl2/fcXk6yWcCy27QZzkgjvPWFrW367q0EqRbyZtFFrxm+O8aYjW3fRwc/TqvQoAU0mpqKsOpyz8X63pmlDuJSD4753C+SLRtj+a5qDpmEJLIt6N1CHl4MRsqHCgTUCPDTD5i5fNiYm/XmSTFYoaOxMughXihOY=" rel="noreferrer" target="_blank">
https://github.com/llvm/llvm-project/commit/d5000e9cd95b720fc9082da6cdcdb2c865303dcf</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/d5000e9cd95b720fc9082da6cdcdb2c865303dcf.diff" originalsrc="https://github.com/llvm/llvm-project/commit/d5000e9cd95b720fc9082da6cdcdb2c865303dcf.diff" shash="NTYmYHkrGaRIFqUkRvvGZhYfEdnsOKUIPi3QZQUYTSHunwvpmDs1Yu+g3Q1VvbQ/6DMm3UkOpUVBIbuGmhjKg0MNa3C+bOEZ0AdSTIVZFAfNXL5lkD4G4Vt4BoOG7K/BA4Q5ErY/owVwB7ss/8yKqX//xtJ9yVmke0JxNnxw5IA=" rel="noreferrer" target="_blank">
https://github.com/llvm/llvm-project/commit/d5000e9cd95b720fc9082da6cdcdb2c865303dcf.diff</a><br>
<br>
LOG: rename to 'try' isntead of 'Try'x<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
clang/lib/Parse/ParseOpenACC.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/clang/lib/Parse/ParseOpenACC.cpp b/clang/lib/Parse/ParseOpenACC.cpp<br>
index 018c61de4be369..a5a028e1c6a799 100644<br>
--- a/clang/lib/Parse/ParseOpenACC.cpp<br>
+++ b/clang/lib/Parse/ParseOpenACC.cpp<br>
@@ -183,7 +183,7 @@ bool isTokenIdentifierOrKeyword(Parser &P, Token Tok) {<br>
/// Return 'true' if the special token was matched, false if no special token,<br>
/// or an invalid special token was found.<br>
template <typename DirOrClauseTy><br>
-bool TryParseAndConsumeSpecialTokenKind(Parser &P, OpenACCSpecialTokenKind Kind,<br>
+bool tryParseAndConsumeSpecialTokenKind(Parser &P, OpenACCSpecialTokenKind Kind,<br>
DirOrClauseTy DirOrClause) {<br>
Token IdentTok = P.getCurToken();<br>
// If this is an identifier-like thing followed by ':', it is one of the<br>
@@ -713,7 +713,7 @@ void Parser::ParseOpenACCCacheVarList() {<br>
// The VarList is an optional `readonly:` followed by a list of a variable<br>
// specifications. Consume something that looks like a 'tag', and diagnose if<br>
// it isn't 'readonly'.<br>
- if (TryParseAndConsumeSpecialTokenKind(*this,<br>
+ if (tryParseAndConsumeSpecialTokenKind(*this,<br>
OpenACCSpecialTokenKind::ReadOnly,<br>
OpenACCDirectiveKind::Cache)) {<br>
// FIXME: Record that this is a 'readonly' so that we can use that during<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" originalsrc="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" shash="uQZVjXz75H4Gpg4ojFAWHk9pmXfHjaRlUnG/Lw+ZGfULVHXHP5eQbz+FQuyPy/4u5AnucPIf6Y8BTCU4bvbln+QkD9y0XhpL6Y4kD7EpU/dMz78Cpy/t9+YSM4W81II11ocerJ3mxWLn3KHkNxovkUhkzcXD/36d23SpNWhLTkU=" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote>
</div>
</div>
</div>
</body>
</html>