<div dir="ltr">Any chance this could/should reference the length by name, rather than by casts and pointer math? (so it's resilient to at least some changes to StringLiteral/StringRef?) Or is this the preferred way to write Natvis visualizers, so they're resilient to missing debug info or something?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Nov 12, 2023 at 6:22 AM Aaron Ballman via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Aaron Ballman<br>
Date: 2023-11-12T09:22:15-05:00<br>
New Revision: 8569465adf5e6c792e88be56b0e6b24f1c74e633<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/8569465adf5e6c792e88be56b0e6b24f1c74e633" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/8569465adf5e6c792e88be56b0e6b24f1c74e633</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/8569465adf5e6c792e88be56b0e6b24f1c74e633.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/8569465adf5e6c792e88be56b0e6b24f1c74e633.diff</a><br>
<br>
LOG: Add a Clang NATVIS visualizer for StringLiteral<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
clang/utils/ClangVisualizers/clang.natvis<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/clang/utils/ClangVisualizers/clang.natvis b/clang/utils/ClangVisualizers/clang.natvis<br>
index 9faaa8a8bba8cf0..0c09d3480b07a9a 100644<br>
--- a/clang/utils/ClangVisualizers/clang.natvis<br>
+++ b/clang/utils/ClangVisualizers/clang.natvis<br>
@@ -1000,8 +1000,15 @@ For later versions of Visual Studio, no setup is required--><br>
</Expand><br>
</Type><br>
<Type Name="clang::Expr"><br>
+ <DisplayString Condition="StmtBits.sClass==clang::Stmt::StmtClass::StringLiteralClass" IncludeView="poly">{*(clang::StringLiteral *)this}</DisplayString><br>
<DisplayString>Expression of class {(clang::Stmt::StmtClass)StmtBits.sClass,en} and type {TR,view(cpp)}</DisplayString><br>
</Type><br>
+ <Type Name="clang::StringLiteral"><br>
+ <Expand><br>
+ <Item Name="Length">*(unsigned *)(((clang::StringLiteral *)this)+1)</Item><br>
+ <Item Name="Data" Condition="StringLiteralBits.NumConcatenated==1">(const char *)(((clang::StringLiteral *)this)+1)+4+4,[*(unsigned *)(((clang::StringLiteral *)this)+1)]s8</Item><br>
+ </Expand><br>
+ </Type><br>
<Type Name="clang::DeclAccessPair"><br>
<DisplayString IncludeView="access" Condition="(Ptr&Mask) == clang::AS_public">public</DisplayString><br>
<DisplayString IncludeView="access" Condition="(Ptr&Mask) == clang::AS_protected">protected</DisplayString><br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>